sarif — archive

[Laurence Golding]

I created and merged a change draft for Issue #397 , “Add more address kinds”: https://github.com/oasis-tcs/sarif-spec/blob/master/Documents/ChangeDrafts/Accepted/sarif-v2.0-issue-397-address-kinds-instruction-data.docx This came up while I was writing a SARIF example for addresses, and I realized a couple of kinds were missing. After discussion with Michael, we decided to add "instruction" and "data". Please take a look. The complete change, including the example, is below. Next is Issue #393 , “Loosen prohibition against array elements in 'root' SARIF document”. Thanks, Larry 3.31.5 kind property … Existing text omitted … "instruction" : A location in memory containing executable code. "data" : A location in memory containing non-executable data. Although a function does contain executable code, the value "function" SHOULD be used for the address of the start of a function, because it is more specific. The value "instruction" SHOULD be used for an address within the body of a function. … Existing text omitted … EXAMPLE: This example illustrates memory locations of various kinds, linked through their parentIndex properties (§ 3.31.7 ). "addresses": [   {     "baseAddress": 4194304,     "fullyQualifiedName": "collections.dll",     "kind": "module",     "section": ".text"   },   {     "offset": 100,     "fullyQualifiedName": "collections.dll!collections::list::add",     "kind": "function",     "parentIndex": 0   },   {     "offset": 22,     "fullyQualifiedName": "collections.dll!collections::list::add+0x16",     "kind": "instruction",     "parentIndex": 1   },   {     "baseAddress": 8388608,     "kind": "data",     "section": ".data"   } ]