[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio] [PATCH v5] virtio-blk: restore VIRTIO_BLK_F_FLUSH and VIRTIO_BLK_F_CONFIG_WCE
On Mon, 10 Aug 2015 15:33:49 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> +\begin{itemize}
> +\item they MUST NOT modify \field{writeback} as a result
> + of a driver's write to the status register.
> + Some legacy drivers wrote to \field{writeback} between
> + setting the DRIVER status bit and setting the DRIVER_OK status bit.
> + Transitional devices MUST NOT overwrite \field{writeback} when
> + the DRIVER_OK status bit is set.
> +
> +\item they MUST NOT modify \field{writeback} as a result of
> + a driver's write to the guest features registers, for example if the
> + driver sets the VIRTIO_BLK_F_CONFIG_WCE guest feature bit but does not
> + set the VIRTIO_BLK_F_FLUSH bit.
> +\end{itemize}
Minor nit (I'm not sure if we do this elsewhere in the document
already): "write to the <foo> register" sounds PCI(/MMIO?) specific.
This is probably better called "driver setting the device status" and
"driver writing the guest features" or something like that.
But we can also correct this later.
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]