virtio — archive

[PATCH] virtio_pci_cap64: bar/BAR cleanups

From: Michael S. Tsirkin
To: [email protected]
Date: Wed, 27 Nov 2019 21:29:00 -0000

When we mean PCI register we should say BAR. When we mean a virtio config register we should say field{cap.bar}. Finally, offset_hi/length_hi are not within the cap structure. Reported-by: Christophe de Dinechin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> --- content.tex 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/content.tex b/content.tex index d68cfaf..75cab0a 100644 --- a/content.tex +++ b/content.tex @@ -763,7 +763,7 @@ subsection{Virtio Structure PCI Capabilities}label{sec:Virtio Transport Option Given that the field{cap.length} and field{cap.offset} fields are only 32 bit, the additional field{offset_hi} and field {length_hi} fields provide the most significant 32 bits of a total 64 bit offset and -length within the bar specified by field{cap.bar}. +length within the BAR specified by field{cap.bar}. drivernormative{subsubsection}{Virtio Structure PCI Capabilities}{Virtio Transport Options / Virtio Over PCI Bus / Virtio Structure PCI Capabilities} @@ -1093,9 +1093,9 @@ subsubsection{Shared memory capability}label{sec:Virtio Transport Options / Vi devicenormative{paragraph}{Device-specific configuration}{Virtio Transport Options / Virtio Over PCI Bus / PCI Device Layout / Shared memory capability} -The region defined by the combination of the field {cap.offset}, -field {cap.offset_hi}, and field {cap.length}, field -{cap.length_hi} fields MUST be contained within the declared bar. +The region defined by the combination of the field{cap.offset}, +field{offset_hi}, and field {cap.length}, field{length_hi} fields +MUST be contained within the BAR specified by field{cap.bar}. The field{cap.id} MUST be unique for any one device instance. -- MST