← Prev in month ← Prev in thread
Next in thread → Next in month →

#358, #366, #367, #368, #369, #370: Change drafts + merge to provisional

From
Laurence Golding
Date
2019-04-13T22:36:00+00:00
ID
Thread
#358, #366, #367, #368, #369, #370: Change drafts + merge to provisional
I have merged several changes into the provisional draft. I grouped them into three change drafts:

https://github.com/oasis-tcs/sarif-spec/blob/master/Documents/ChangeDrafts/Accepted/sarif-v2.0-issues-366-367-369-370.docx
This is by far the biggest set of changes.
Issue #366 is Jim Kupsch’s feedback, which was extensive.  See this issue comment to see the list of changes:
https://github.com/oasis-tcs/sarif-spec/issues/366#issuecomment-481827464 .  See this issue comment for the resulting schema changes:
https://github.com/oasis-tcs/sarif-spec/issues/366#issuecomment-481916935 .
This draft also includes fixes for dozens of typos found by Henny.
Finally, although the title doesn’t say so, this draft includes one of the three property renames from  Issue #368 :
artifactLocation.artifactIndex => index . I had intended to include them all but I pushed the draft prematurely. And so…
https://github.com/oasis-tcs/sarif-spec/blob/master/Documents/ChangeDrafts/Accepted/sarif-v2.0-issue-368-renames.docx
This draft includes the other two renames from Issue #368:
artifact.artifactLocation => location  and
attachment.artifactLocation => location
The  artifactLocation  rename is non-trivial because there are two places where the property name  artifactLocation  actually makes sense, IMO, and so I kept it: in the  physicalLocation  object and in the
artifactChange  object. I scrubbed all hundred-odd occurrences of
artifactLocation  to make sure they were all correct (at least by my lights).
https://github.com/oasis-tcs/sarif-spec/blob/master/Documents/ChangeDrafts/Accepted/sarif-v2.0-issue-358-originalUriBaseId-resolution.docx
This is another suggestion from Jim. We make certain restrictions on the values of the  uri  properties in
run.originalUriBaseIds  to ensure that you can safely resolve a
uriBaseId  by concatenating URIs. See
Issue #358  for a variety of approaches suggested by Jim, and for the approach that Michael and I landed on.

As always, the provisional draft is up to date with all these changes:

https://github.com/oasis-tcs/sarif-spec/blob/master/Documents/ProvisionalDrafts/sarif-v2.0-csd02-provisional.docx

There are only a few more issues I intend to address: #323, #364, and #365. Here is the full query:

https://github.com/oasis-tcs/sarif-spec/issues

There is one more proposal from Jim (“related location relationships”) which I’d love to get to but not sure I can fit it in (at least, not in time for the TC to review it).

Thanks to all for your work to bring the spec to this point. We’re almost home!

Larry
← Prev in month ← Prev in thread
Next in thread → Next in month →