Re: [sca-bindings] BINDINGS-170: Test_BWS_2021.composite - confusing test comment

Logged as http://www.osoa.org/jira/browse/BINDINGS-170

Simon Holdsworth

----- Forwarded by Simon
Holdsworth/UK/IBM on 10/11/2011 13:10 -----

From:      
 Simon Holdsworth/UK/IBM

To:      
 

Date:      
 07/11/2011 13:55

Subject:    
   NEW ISSUE: Test_BWS_2021.composite
- confusing test comment

TARGET: WS Binding Testcase artefacts

DESCRIPTION: 

As reported in public review comment: 

http://lists.oasis-open.org/archives/sca-bindings-comment/201109/msg00000.html

This XML comment in Test_BWS_2021.composite
was confusing me 

        <reference name="Reference1">

            <!-- binding.ws has a @wsdlElement
attribute with a value that points to WSDL service element 

                 and this
element has an invalid WSDL port element defined -->

                <binding.ws
uri="&ws_addr_2021;" /> 

        </reference> 

until I realized it had apparently been copied over from Test_BWS_2005.composite.
  

It also shows up in Test_BWS_2007.composite, Test_BWS_2013.composite, though
it's almost correct enough in those contexts. 

PROPOSAL:

Correct comment text in Test_BWS_2021.composite, Test_BWS_2007.composite
and Test_BWS_2013.composite to be applicable for each case, as below.

The comment for Test_BWS_2021.composite should read:

<-- binding.ws on the reference has a valid target
defined by means of its @uri attribute.  -->

For Test_BWS_2007.composite the comment should read:

<!-- binding.ws has a @wsdlElement attribute with
a value that points to WSDL port element 

     whose interface is incompatible
with that defined for the service. -->

For Test_BWS_2013.composite the comment should read:

<!-- binding.ws has a @wsdlElement attribute with
a value that points to WSDL binding element 

     whose binding type is not supported
by the SCA runtime. -->

Simon Holdsworth

Unless stated otherwise above:

IBM United Kingdom Limited - Registered in England and Wales with number
741598. 

Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU