ISSUE 130: Problems with Example 3 in chapter 7

http://www.osoa.org/jira/browse/JAVA-130

Dave Booz

STSM, BPM and SCA Architecture

Co-Chair OASIS SCA-Policy TC and SCA-J TC

"Distributed objects first, then world hunger"

Poughkeepsie, NY (845)-435-6093  or  8-295-6093

e-mail:

Simon Nash ---02/09/2009 10:26:45 AM---TARGET: Java Common Annotations and APIs DESCRIPTION: Problems with Example 3 in chapter 7

From:

Simon Nash <>

To:

OASIS Java <>

Date:

02/09/2009 10:26 AM

Subject:

[sca-j] NEW ISSUE: Problems with Example 3 in chapter 7

TARGET: Java Common Annotations and APIs

DESCRIPTION: Problems with Example 3 in chapter 7

There are a number of problems with Example 3 in section 7.6.2.1

of cd02-rev2.

  a. The fromUSDollarToCurrency method is not declared in the

     AccountService interface.  It only appears in the

     implementation class.  It appears that this omission is

     accidental, not deliberate.

  b. The calls from getAccountReport() to fromUSDollarToCurrency()

     don't use SCA; they are just plain Java calls.  It appears

     they were intended to be SCA calls.

  c. The code in getAccountReport() has excessive detail and is

     poorly formatted.  This makes it hard to understand the

     point of the example.

  d. The code in fromUSDollarToCurrency() has some "return"

     statements followed by "else", with unusual formatting.

     There is no need for "else" after "return".

PROPOSAL:

Add the fromUSDollarToCurrency method to the AccountService

interface.

Change the calls from getAccountReport() to fromUSDollarToCurrency()

into SCA calls, using the ComponentContext.getSelfReference() method.

Remove unnecessary detail from getAccountReport() and improve

its formatting.

Remove redundant "else" clauses from fromUSDollarToCurrency() and

improve its formatting.

---------------------------------------------------------------------

To unsubscribe from this mail list, you must leave the OASIS TC that

generates this mail.  Follow this link to all your TCs in OASIS at:

https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php