Bryan,
Many thanks for doing this piece of
work.
Some comments:
1) TestCases document - new testcase
POJO_8037_TestCase
The description should be made more
precise about the expected content of the @requires attribute, since the
associated test assertion is more precise.
My suggestion is to change:
"Tests that an implementation class
annotated with a javax.xml.ws.BindingType annotation has a component type
with a <binding.ws/> element
with @requires attribute containing the correct intent"
to read:
Tests that an implementation class annotated
with a javax.xml.ws.BindingType annotation, where the value of the
@BindingType annotation is http://www.w3.org/2003/05/soap/bindings/HTTP/,
has a component type with a <binding.ws/>
element with an @requires attribute
which contains the intent "SOAP.v1_2”
2) POJO_8037_TestCase.java &
Test_POJO_8037.composite
Description should be changed to match
the description in the testcases document as above
3) Test_POJO_8037.composite
To ensure that the mutual exclusion
of the intents works correctly, I believe that it would be better for the
requires="SOAP.v1_1"
attribute ot be placed directly on the
<service/> element of TEST_POJO_8037Component1, rather than on the
<reference/>
element which is wired to that <service/>
element. While the current design SHOULD work, I am left a little
nervous that the
exclusion could be lost if the binding
type offers both SOAP 1.1 & SOAP 1.2 and decides that SOAP 1.1 can
always be
accommodated by SOAP 1.2 (or some such
similar idea).
This means that the composite should
be changed to the following:
<composite xmlns="http://docs.oasis-open.org/ns/opencsa/sca/200912"
targetNamespace="http://docs.oasis-open.org/ns/opencsa/scatests/200903"
xmlns:test="http://docs.oasis-open.org/ns/opencsa/scatests/200903"
name="TEST_POJO_8037">
<component name="TestClient">
<implementation.composite name="test:TestClient_0002"/>
<service name="TestInvocation">
<interface.wsdl
interface="http://test.sca.oasisopen.org/#wsdl.porttype(TestInvocation)"/>
<binding.ws/>
</service>
<reference
name="reference1" target="TEST_POJO_8037Component1/Service1"/>
<property
name="testName">POJO_8037</property>
</component>
<!-- Component with
an implementation which has a @BindingType annotation -->
<component name="TEST_POJO_8037Component1">
<!--
Implementation class has a @SOAPBinidng annotation -->
<implementation.java
class="org.oasisopen.sca.test.Service1JWSBindingTypeImpl"/>
<service
name="Service1" requires="SOAP.v1_1">
<interface.java interface="org.oasisopen.sca.test.Service1"/>
</service>
<property
name="serviceName">service1</property>
</component>
</composite>
Yours, Mike.
Strategist - Emerging Technologies, SCA & SDO.
Co Chair OASIS SCA Assembly TC.
IBM Hursley Park, Mail Point 146, Winchester, SO21 2JN, Great Britain.
Phone & FAX: +44-1962-818014 Mobile: +44-7802-467431
Email:
From:
Bryan Aupperle <>
To:
Date:
14/10/2010 20:45
Subject:
[sca-j] ISSUE 214: Test Suite Impacts
of Issue 204
I have uploaded a proposal. [1]
Contains updates for both the test assertions and test cases. The
proposed test artifacts can be found at [2].
[1] https://www.oasis-open.org/apps/org/workgroup/sca-j/download.php/39818/Issue%20214%20proposal.zip
[2] http://tools.oasis-open.org/version-control/browse/wsvn/sca-j/TestCases_POJO_CI/?rev=202&sc=1
Bryan Aupperle, Ph.D.
STSM, WebSphere Enterprise Platform Software Solution Architect
WW Center of Excellence for Enterprise Systems & Banking Center of
Excellence Application Integration Architect
Research Triangle Park, NC
+1 919-254-7508 (T/L 444-7508)
Internet Address:
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
3AU
