Re: [PATCH v3 2/3] shared memory: Define PCI capability

On Mon, Mar 04, 2019 at 01:25:30PM +0000, Dr. David Alan Gilbert (git) wrote:
> +\begin{lstlisting}
> +struct virtio_pci_shm_cap {
> +        struct virtio_pci_cap cap;
> +        u32 offset_hi;
> +        u32 length_hi;
> +        u8  id;
> +};
> +\end{lstlisting}

Are there any alignment requirements for PCI capability structures?
This struct ends with a u8, which might be a problem if 32-bit or 64-bit
alignemnt is required by something.

Otherwise:

Reviewed-by: Stefan Hajnoczi <>