Re: [virtio-comment] Clarifying section "2.6.12 virtqueue Operation" in virtio-v1.1

From
Ariel Adam <>
Date
2019-05-28T12:32:03+00:00
ID
Thread
Re: [virtio-comment] Clarifying section "2.6.12 virtqueue Operation" in virtio-v1.1
Sending the actual patch to the list (let me know if anything is missing):

---
Â0001-REVISION-update-to-wd02.patch | 20 ++++++++++++++++++++
Âsplit-ring.tex           | 10 +++++-----
Â2 files changed, 25 insertions(+), 5 deletions(-)
Âcreate mode 100644 0001-REVISION-update-to-wd02.patch

diff --git a/0001-REVISION-update-to-wd02.patch b/0001-REVISION-update-to-wd02.patch
new file mode 100644
index 0000000..ab090ec
--- /dev/null
+++ b/0001-REVISION-update-to-wd02.patch
@@ -0,0 +1,20 @@
+From 37057052e716c6c02c9391342cbc7263f44759f6 Mon Sep 17 00:00:00 2001
+From: "Michael S. Tsirkin" <>
+Date: Wed, 27 Mar 2019 18:19:19 -0400
+Subject: [PATCH] REVISION: update to wd02
+
+Signed-off-by: Michael S. Tsirkin <>
+---
+ REVISION | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/REVISION b/REVISION
+index beec734..b1157d4 100644
+--- a/REVISION
++++ b/REVISION
+@@ -1 +1 @@
+-virtio-v1.1-wd01
++virtio-v1.1-wd02
+-- 
+1.8.3.1
+
diff --git a/split-ring.tex b/split-ring.tex
index 123ac9f..5148ac8 100644
--- a/split-ring.tex
+++ b/split-ring.tex
@@ -567,11 +567,11 @@ \subsection{Virtqueue Operation}\label{sec:Basic Facilities of a Virtio Device /
Âthe device.
Â
Â\begin{note} As an
-example, the simplest virtio network device has two virtqueues: the
-transmit virtqueue and the receive virtqueue. The driver adds
-outgoing (device-readable) packets to the transmit virtqueue, and then
-frees them after they are used. Similarly, incoming (device-writable)
-buffers are added to the receive virtqueue, and processed after
+the simplest virtio network device has two virtqueues: the 
+transmit virtqueue and the receive virtqueue. The driver adds 
+outgoing packets as device-readable buffers to the transmit virtqueue, and then 
+frees them after they are used. Similarly, device-writable buffers for incoming 
+packets are added to the receive virtqueue, and processed after 
Âthey are used.
Â\end{note}
Â
-- 
1.8.3.1

On Tue, May 21, 2019 at 2:06 AM Michael S. Tsirkin <> wrote:

Can you please send the patch to the list?

We don't process pull requests at this point.

On Mon, May 20, 2019 at 06:18:58PM +0300, Ariel Adam wrote:

> Sent a patch to split-ring.tex:

> 

> https://github.com/oasis-tcs/virtio-spec/pull/44

> 

> Thanks.Â

> 

> On Thu, May 16, 2019 at 5:49 PM Stefan Hajnoczi <> wrote:

> 

>Â Â ÂOn Wed, May 15, 2019 at 02:42:32PM +0300, Ariel Adam wrote:

>Â Â Â> Fixes: https://github.com/oasis-tcs/virtio-spec/issues/43

>Â Â Â>

>Â Â Â> We'd like to propose clarifying the usage of packets and buffers in

>Â Â Âsection

>Â Â Â> "2.6.12 virtqueue operation" as described in the github issue above.

> 

>Â Â ÂLooks good to me, do you want to send a patch to content.tex?

> 

>Â Â ÂStefan

>