RE: [EXT] [PATCH v1 2/7] virtio-net: Add flow filter capabilities read commands

From
Parav Pandit <>
Date
2023-10-16T16:35:26+00:00
ID
Thread
RE: [EXT] [PATCH v1 2/7] virtio-net: Add flow filter capabilities read commands
> From: Satananda Burla <>
> Sent: Monday, October 16, 2023 5:10 AM
> 
> Hi Parav
> 
> > +For the \field{type} of VIRTIO_NET_FF_ETH_HDR, header fields are
> > +represented by a bitmap in \field{fields_bmap} are following:
> > +
> > +\begin{tabular}{|l|l|l|}
> > +\hline
> > +Bit & Name & Description \\
> > +\hline \hline
> > +0   & VIRTIO_NET_FF_DST_MAC & Destination MAC address in the packet  \\
> > +\hline
> > +1   & VIRTIO_NET_FF_SRC_MAC & Source MAC address in the packet \\
> > +\hline
> > +2   & VIRTIO_NET_FF_ETHER_TYPE & Ether type in the packet \\
> > +\hline
> > +\end{tabular}
> How about vlan ? if a filter selects ETHER_TYPE as vlan (0x8100), How to then
> match the vlanid ? I believe I mentioned this in last series as well.

I am sorry, I noticed now that I missed this comment in v0.
For VLAN, we need to add a new filter as FF_ETH_VLAN, that has implicit type of 0x8100, and match field, mask to have the value.
Shall we can do incrementally as new type?