Re: [virtio] [PATCH] initialization: add extra device status handshake

From
Rusty Russell <>
Date
2013-09-16T07:49:53+00:00
ID
Thread
Re: [virtio] [PATCH] initialization: add extra device status handshake
"Michael S. Tsirkin" <> writes:
> In the past we sometimes wanted an ability to make driver
> gracefully fail early in initialization if it does not
> recognize/support a feature.  One such example we are introducing
> right now is the new VERSION_1 feature.
>
> Another example where the driver configuration
> is inconsistent with what the device can support.
>
> This modifies the initialization to allow
> graceful failure in such cases:
> 1. require a driver to first ack all features it recognizes
> (linux does this already)
> 2. require driver to set status after configuration
> and re-check status afterwards
>
> This resolves issue VIRTIO-30.

I take back my previous comments.  This solution is remarkably graceful,
and nicely optional.

BTW, I put the URL of your patch from the ml archives into the
"Proposal" field of the virtio-30 bug report for you and marked it Open.
If we get more discussion, or a revised patch, we can revisit.

Cheers,
Rusty.