Hi Michael,
"Michael S. Tsirkin" <> writes:
> On Sun, Feb 14, 2016 at 08:18:05AM -0500, Aaron Conole wrote:
<<snip>>
>> +
>> +\item[VIRTIO_NET_F_MTU(24)] Negotiated MTU is supported. If
>> + offered by the device, device advises driver about the value of
>> + MTU to be used. If negotiated, the driver uses \field{mtu} as
>> + the MTU value.
>
> I would add:
>
> ... supplied to the operating system.
>
> Note: many operating systems override the MTU
> value provided by the driver.
>
done
<<snip>>
>> +A driver SHOULD negotiate VIRTIO_NET_F_MTU if the device offers it. A driver
>> +MUST use \field{mtu} if it negotiates VIRTIO_NET_F_MTU. A driver MUST NOT
>> +negotiate VIRTIO_NET_F_MTU if it does not use \field{mtu} as the MTU.
>> +
>
> I would drop "as the MTU" here.
and done.
Thanks so much for the review, Michael!
-Aaron
