Re: [virtio-dev] virtio-blk: the nature of discard_sector_alignment

On 2/22/19 2:59 PM, Paolo Bonzini wrote:
> On 22/02/19 10:41, Jakub Jermar wrote:
>>>> Does discard_sector_alignment represent a strict requirement that must
>>>> be always honored or is it rather a hint to the driver?
>>>
>>> It's a hint that misaligned requests might not result in any discard
>>> happening at all.
>>
>> In that case, would the failure to discard anything be silent? In other
>> words, would the request complete with VIRTIO_BLK_S_OK or rather any of
>> VIRTIO_BLK_S_IOERR or VIRTIO_BLK_S_UNSUPP?
> 
> Yes, it would be silent.  The same is true for NVMe, SCSI etc.

Thanks, this helped a lot.

Jakub

-- 
Kernkonzept GmbH at Dresden, Germany, HRB 31129, CEO Dr.-Ing. Michael
Hohmuth