Re: [virtio-dev] Re: [PATCH V2] virtio: i2c: Allow zero-length transactions

From
Viresh Kumar <>
Date
2021-08-23T07:31:41+00:00
ID
20210823073137.qsljjifenagq5jrb@vireshk-i7
Thread
Re: [virtio-dev] Re: [PATCH V2] virtio: i2c: Allow zero-length transactions
On 18-08-21, 13:39, Viresh Kumar wrote:
> On 18-08-21, 10:03, Arnd Bergmann wrote:
> > I'd prefer your earlier approach.
> > 
> > My feeling is that changing the virtqueue code to allow zero-length
> > buffers is more fragile than having something in the virtio-i2c code
> > that has a special case for leaving out both read_buf and write_buf.
> 
> Exactly what I think about it and so my hesitation for the same :)
> 
> > Even if we fix the linux virtqueue code to deal with zero-length
> > NULL buffers, there are other implementations that will require
> > similar workarounds for existing sanity checks.
> 
> Lets say what Michael thinks about it.

Michael, do you want to re comment on this ?

-- 
viresh