Re: [virtio-dev] [PATCH v2] content: Remove duplicate paragraph

From
Stefan Hajnoczi <>
Date
2021-10-07T08:41:37+00:00
ID
Thread
Re: [virtio-dev] [PATCH v2] content: Remove duplicate paragraph
On Wed, Oct 06, 2021 at 12:28:19PM +0100, Jean-Philippe Brucker wrote:
> It looks like commit 356aeeb40d7a ("content: add vendor specific cfg
> type") had a merge issue. It includes the device normative paragraph for
> Shared memory capability, which was already added right above it by
> commit 855ad7af2bd6 ("shared memory: Define PCI capability").
> 
> The two paragraphs differ, and the first paragraph is correct. It refers
> to struct virtio_pci_cap64 which embeds struct virtio_pci_cap:
> 
>   struct virtio_pci_cap64 {
>     struct virtio_pci_cap {
>       ...
>       le32 offset;
>       le32 length;
>     } cap;
>     u32 offset_hi;
>     u32 length_hi;
>   }
> 
> Merge the two paragraph while keeping the best of both. Drop the spaces
> after \field to stay consistent with the rest of the document.
> 
> Acked-by: Michael S. Tsirkin <>
> Signed-off-by: Jean-Philippe Brucker <>
> ---
> v1: https://www.mail-archive.com/[email protected]/msg07815.html
> ---
>  content.tex | 15 ++++-----------
>  1 file changed, 4 insertions(+), 11 deletions(-)

Reviewed-by: Stefan Hajnoczi <>