Next in thread →
Next in month →
Re: [PATCH v2] content: Remove duplicate paragraph
On Wed, Oct 06 2021, Jean-Philippe Brucker <> wrote:
> It looks like commit 356aeeb40d7a ("content: add vendor specific cfg
> type") had a merge issue. It includes the device normative paragraph for
> Shared memory capability, which was already added right above it by
> commit 855ad7af2bd6 ("shared memory: Define PCI capability").
>
> The two paragraphs differ, and the first paragraph is correct. It refers
> to struct virtio_pci_cap64 which embeds struct virtio_pci_cap:
>
> struct virtio_pci_cap64 {
> struct virtio_pci_cap {
> ...
> le32 offset;
> le32 length;
> } cap;
> u32 offset_hi;
> u32 length_hi;
> }
>
> Merge the two paragraph while keeping the best of both. Drop the spaces
> after \field to stay consistent with the rest of the document.
>
> Acked-by: Michael S. Tsirkin <>
> Signed-off-by: Jean-Philippe Brucker <>
> ---
> v1: https://www.mail-archive.com/[email protected]/msg07815.html
> ---
> content.tex | 15 ++++-----------
> 1 file changed, 4 insertions(+), 11 deletions(-)
Thanks, pushed as an editorial update.
[While looking at this, I noticed that the normative statements for the
vendor data capability are not at the correct level. I'll do a patch to
fix that.]
Next in thread →
Next in month →