Re: [RFC PATCH v2 1/2] virtio-gpu: add resource create blob

[Gerd Hoffmann <kraxel@redhat.com>]

> +\item[VIRTIO_GPU_CMD_SET_SCANOUT_BLOB] sets scanout parameters for a
> +   blob resource. Request data is
> +  \field{struct virtio_gpu_set_scanout_blob}. Response type is
> +  VIRTIO_GPU_RESP_OK_NODATA. Support is optional and negotiated
> +  using the VIRTIO_GPU_F_RESOURCE_BLOB feature flag.
> +
> +\begin{lstlisting}
> +struct virtio_gpu_set_scanout_blob {
> +       struct virtio_gpu_ctrl_hdr hdr;
> +       struct virtio_gpu_rect r;
> +       le32 scanout_id;
> +       le32 resource_id;
> +       le32 width;
> +       le32 height;
> +       le32 format;
> +       le32 padding;
> +       le32 strides[4];
> +       le32 offsets[4];
> +};
> +\end{lstlisting}
> +
> +The rectangle \field{r} represents the portion of the blob resource being
> +displayed. The rest is the metadata associated with the blob resource. The
> +format MUST be one of \field{enum virtio_gpu_formats}.

So you've changed strides & offsets to arrays, for planar formats.
We don't have any planar formats in virtio_gpu_formats though ...

So add a note that this is for future planar format support?
Or do we want add planar formats now?

Also: should resource_id an array too?  So we have the option to store
each plane in a different resource (simliar to drm_framebuffer in the
linux kernel)?

cheers,
  Gerd